Merged
Conversation
- Add QuoteExecuted variant to CommunicationData WebSocket enum - Add serde defaults to Series fields for API resilience - Fix order_groups endpoint path in API docs - Add WS communication channel tests (rfq/quote lifecycle) - Remove noisy ping info log (pong already logged at debug) - Remove redundant cursor() doc comments for consistency - Bump version to 0.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuoteExecutedvariant onCommunicationDataenum for WebSocket quote execution notifications (QuoteExecutedDatawithquote_id,rfq_id,order_id,client_order_id,executed_ts). Previously, quote execution events on thecommunicationschannel were silently dropped.#[serde(default)]to severalSeriesfields (tags,settlement_sources,contract_url,contract_terms_url,fee_type,fee_multiplier,additional_prohibitions) to prevent deserialization failures when the API omits them.create_order_groupendpoint path in API docs (/portfolio/order_groups/create).rfq_created,rfq_deleted,quote_created,quote_accepted,quote_executed, and tagged enum dispatch).info!-level ping log (pong already logged atdebug), removed redundantcursor()doc comments for consistency, removed trivialCommunicationsSharding::defaulttest.Breaking change
CommunicationDatagained a new variant (QuoteExecuted), which is a breaking change for exhaustive match arms.Test plan
cargo test— 200 unit tests pass, 21 doc-tests passcargo clippy— clean